fix python versions of build wheels by removing the universal flag #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
pushed a commit
that referenced
this pull request
Sep 11, 2018
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
currently the built wheel files still have the extension
py2.py3-none-any.whlindicating python2 and python3 compatibility (for example jupyterlab-0.34.8-py2.py3-none-any.whl). As jupyterlab is python3 only since 40530f8 this pull requests removes the universal flag as it indicates that both versions are supported (see https://wheel.readthedocs.io/en/stable/#defining-the-python-version).This will result in wheels like
jupyterlab-0.35.0a0-py3-none-any.whl.